removes non essential calls to File.exist?#3
Merged
eelcoj merged 1 commit intoRails-Designer:mainfrom Feb 16, 2026
Merged
Conversation
Contributor
|
Oh, interesting one. Thanks also for profiling. I'll give this a try soon, as I only recently extracted the core into this new gem I am careful of adding many new changes. This is looking good; will give it a try. Thanks! |
Contributor
|
Thanks for this @nflorentin! ✨ Just merged, This behaviour was already tested. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if not raising Icons::IconNotFound in Icon::FilePath class is problematic or not ?
I think it is not a problem if the exception is raised when reading the file instead of when the path is built.
issue #2