Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

@Techwolfy
Copy link
Contributor

@Techwolfy Techwolfy commented May 17, 2018

The PHP libraries bundled with RainLoop are old and updated infrequently. Composer is to PHP what NPM is to JS, and makes it much easier to keep up-to-date. gulp-composer handles updates without requiring external binaries, so I was able to embed it into the main JS build process.

Additionally, it's good practice to avoid bundling multiple projects within a single git repository; unless they're heavily intertwined and all maintained by the same person/group, keeping them separate makes updates and licensing much easier.

@phsc84
Copy link

phsc84 commented Aug 16, 2018

Also this PR, I consider highly useful. Would be great if you could merge it.

@Techwolfy Techwolfy force-pushed the upstream branch 2 times, most recently from 07b7fac to 1d77dd0 Compare September 8, 2018 03:04
@Techwolfy
Copy link
Contributor Author

@RainLoop Rebased on current master. Please merge this, or let me know if there's anything you'd like me to do differently.

@Techwolfy
Copy link
Contributor Author

@RainLoop Rebased. Is this project still maintained? I don't want to keep working on Rainloop if the project has been abandoned.

@phsc84
Copy link

phsc84 commented Mar 7, 2019

@RainLoop It is really sad, that you completely ignore pull requests like this. This way you frustrate developers, willing to contribute to your project. And that's the reason why an open source community dies.

@bugz8unny69
Copy link

@Techwolfy How about we just fork it? It's open source?

@Techwolfy
Copy link
Contributor Author

I currently maintain the Debian package for Rainloop, which includes my PRs here along with a few other changes incidental to the packaging process. That repository is hosted on https://salsa.debian.org/js-team/rainloop.

Unfortunately I don't have the time to maintain a full fork, especially if upstream isn't interested in merging changes. I don't mind making minor changes to my PRs or rebasing for a merge at @RainLoop's request, but I won't be continuing work on RainLoop beyond maintaining the package.

@bugz8unny69
Copy link

Hello,

I plan to fork it and merge PRs and fix issues I come across there and there. Maintaining is a undertaking and I don't have any desire to implement new features.

Is it dead or not dead is very unclear. Cheers.

@Techwolfy Techwolfy force-pushed the upstream branch 2 times, most recently from 39e5a27 to 20a6ea3 Compare April 1, 2019 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants