This repository was archived by the owner on Nov 4, 2024. It is now read-only.
Reduce and unbundle JS dependencies. #1698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techwolfy
force-pushed
the
unbundle
branch
10 times, most recently
from
35f8eb8 to
0e545f6
Compare
|
Why do you not merge this PR? In my opinion it is highly useful. |
Contributor
Author
|
@RainLoop Merge conflicts resolved. Please merge this, or let me know if there's anything you'd like me to do differently. |
Techwolfy
force-pushed
the
unbundle
branch
3 times, most recently
from
47607a3 to
96121ff
Compare
Contributor
Author
|
@RainLoop Rebased. Is this project still maintained? I don't want to keep working on Rainloop if the project has been abandoned. |
|
@RainLoop It is really sad, that you completely ignore pull requests like this. This way you frustrate developers, willing to contribute to your project. And that's the reason why an open source community dies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excessive dependencies make repackaging more difficult (e.g. for distribution with Debian) and can cause security issues. It is also far more beneficial to the community to contribute patches upstream rather than bundling a modified copy, unless the upstream maintainer rejects them.
The goal of this PR is to reduce the total number of dependencies in the project by replacing rarely-used libraries with plain JS, and by replacing vendored libraries with updated versions through NPM. Feel free to merge it at any time; each commit can be taken independently, and I will file additional PRs for continued work if necessary.