This repository was archived by the owner on Nov 4, 2024. It is now read-only.
Custom SQL password plugin - SQL injection vulnerability fix #1791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue:
#1790
It fixes the SQL injection vulnerability that I found in this plugin.
I rewrote the database code to make use of PDO prepared statement and bound variables instead of
str_replace().I also improved the description in the plugin config.
I tried to respect backwards compatibility with the current version of the plugin, so that current users of the plugin won't need to re-write their custom queries.
However it could conceivable fail for a few edge cases. For example, PDO prepared statements can't have dynamic column names such as
SELECT :domain .... But who would want this?