This repository was archived by the owner on Nov 4, 2024. It is now read-only.
[WIP] Fix non quoted LIST command, failing on brackets [label]/ #1818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMD:
* LIST (\HasNoChildren) "/" [label]/Trashfailed because the parser sees the [ as opening for arguments or comments.Google for example returns it quoted:
* LIST (\HasNoChildren) "/" "[Gmail]/Trash"then this is no issue.In the LIST context this failed with a MailSo-Base-Exceptions-InvalidArgumentException, the ResponseList[4] was parsed as a array instead of a string.
This problem exists with Dovecot 2.2
This exception is nicely handled so you won't notice. But it the folders menu it won't show the subfolders because it exits the loop with a exception.
My proposal is quite simple, just check it the current buffered line has LIST at the beginning and checking if current sChar === '[' and is not a LIST command.
Original error:
Output unmodified code: