feat: improve error verbosity and resilience#4
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances runtime error visibility by improving error logging and adjusting messaging behavior during task checks.
- Updated string quote style to double quotes for consistency.
- Enhanced error logging in jiraRequest to include additional error details.
- Adjusted checkTasks messaging and ensured an explicit process exit when no tasks are found.
Files not reviewed (1)
- package.json: Language not supported
kwaszczuk
force-pushed
the
kwaszczuk/patch-2
branch
2 times, most recently
from
b245af7 to
85ab5bf
Compare
kwaszczuk
force-pushed
the
kwaszczuk/patch-2
branch
from
82546f8 to
ac15bf8
Compare
kwaszczuk
force-pushed
the
kwaszczuk/patch-2
branch
2 times, most recently
from
35796c3 to
270d066
Compare
kwaszczuk
force-pushed
the
kwaszczuk/patch-2
branch
from
270d066 to
2e4ee64
Compare
kwaszczuk
changed the title
kwaszczuk
changed the title
papaslon
reviewed
Apr 3, 2025
papaslon
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recently Jira API become a little unstable, randomly returning 403 for valid requests. To workaround this issue I added retries to those requests using
axios-retrylibrary.Additionally, I improved the logging verbosity when any error occurs to make it easier to troubleshoot an issue once it occurs.
Last but not least, I applied some linting changes made by biome.
Quality Assurance
Tested by triggering the Kanar version from this PR here: https://github.com/RampNetwork/ramp-instant/pull/23464