Skip to content

fix: broken fail message formatting#6

Merged
kwaszczuk merged 1 commit intomainfrom
kwaszczuk/fix-fail-msg
Apr 11, 2025
Merged

fix: broken fail message formatting#6
kwaszczuk merged 1 commit intomainfrom
kwaszczuk/fix-fail-msg

Conversation

@kwaszczuk
Copy link
Copy Markdown

@kwaszczuk kwaszczuk commented Apr 11, 2025

Error message when no Jira issue key is found is incorrectly formatted due to trailing whitespaces:

image

Wrapping each line in <p> tag solves an issue.

Copilot AI review requested due to automatic review settings April 11, 2025 11:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

dangerfile.js:65

  • Consider removing unintended extra whitespace and newlines in the fail message string so that the bold and italic parts render consistently across environments. Ensuring a continuous and clean format could help avoid confusion in the message's visual output.
`<b>Please add the Jira issue key at the end of PR title e.g.: #DATA-98</b> (remember to add hash)`

@kwaszczuk kwaszczuk force-pushed the kwaszczuk/fix-fail-msg branch from 327497a to 05bfe1d Compare April 11, 2025 11:36
@kwaszczuk kwaszczuk force-pushed the kwaszczuk/fix-fail-msg branch from 05bfe1d to 475461b Compare April 11, 2025 11:44
@lukaszjaskowski lukaszjaskowski requested a review from a team April 11, 2025 11:50
@kwaszczuk kwaszczuk merged commit b9a4892 into main Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants