-
Notifications
You must be signed in to change notification settings - Fork 291
V1.3 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update codebase to es6 - Add stats cache for sockets - updates every 2.5 secs - Sockets runs on same port as Express server - Move server code to Generator init methods (WIP) - Update gulp scripts to be gulp 4 compatible - Add key/value store instead of referencing global variables throughout app
- Previously using RUG v0.4, which is much slower
- Fetch api stats immediately upon launch - Update socket.io to latest version - Removed old api route path - inject 30 day avg directly into donate ejs page
- Add 1.2 and 1.3 version properties to request schema
- Simplified routing for default api - API now uses generate method instead of instantiating new object for every job
- Use native js dates instead of moment for ~60% increase in dates calculation - Email addresses are now transliterated - More street/city names for NL dataset - Fixed Norwegian id generation bug
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage ? 93.95%
=========================================
Files ? 92
Lines ? 2267
Branches ? 332
=========================================
Hits ? 2130
Misses ? 137
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Use native js dates instead of moment for ~60% increase in dates calculation
• Email addresses are now transliterated
• More street/city names for NL dataset
• Add country name to location block
• Capitalized proper nouns
• Split street into number and name properties
• Fixed Norwegian id generation bug
• Fixed Switzerland phone number format
• Fixed Danish CPR number calculation