docs(claude-md): refresh stale gotchas (RAN-13)#63
Merged
Conversation
- Replace "Virtual thread pinning: use synchronized (not ReentrantLock)" with current state: on JDK 25 + JEP 491 neither primitive pins a virtual-thread carrier; AnalysisCache uses ReentrantReadWriteLock to serialize writes against H2's MVStore while allowing parallel reads. - Bump CACHE_VERSION mention from "currently 2" to "currently 4" to match cache/AnalysisCache.java. - Extend Neo4j indexes bullet with label_lower/fqn_lower + the two fulltext indexes actually created by enrich. Co-Authored-By: Paperclip <noreply@paperclip.ing> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review follow-up for RAN-13.
CLAUDE.mdcarried three stale gotchas thatcontradicted the current code and would mislead future contributors.
What changed
synchronizedblocks (notReentrantLock)" with the real story: on JDK 25 + JEP 491 neithersynchronizednorjava.util.concurrent.locks.*pins a virtual-threadcarrier, so the lock primitive is no longer the constraint.
AnalysisCacheusesReentrantReadWriteLockso virtual threads canread in parallel while writes stay serialized — which is what prevents
ClosedChannelExceptionagainst H2's MVStore file channel."currently 4" to match
cache/AnalysisCache.java.label_lower,fqn_lower, and the two fulltext indexes (search_index,lexical_index) actually created incli/EnrichCommand.java.Docs-only change, no code touched.
Test plan
CLAUDE.mdmodified.cache/AnalysisCache.java(CACHE_VERSION = 4,ReentrantReadWriteLock),cache/FileHasher.java(SHA-256), and theCypher index DDL in
cli/EnrichCommand.java.Closes RAN-13.