feat(charts): Charts module + ServiceMap with degree sizing, focus hi…#1
Merged
feat(charts): Charts module + ServiceMap with degree sizing, focus hi…#1
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…ghlight, directional edges
…files The PR previously imported chart prop types from "../components" but never declared them — typecheck failed with ~50 errors. This commit makes the branch buildable end-to-end against current main. src/components.ts — add chart prop interfaces (CHARTS section): RenderEngine, ChartType, ChartPoint, ChartSeries, ChartProps, SparklineProps, DonutSegment, DonutProps, RadialGaugeProps, UptimeStatus, UptimeCell, UptimeBarProps, TreemapNode, TreemapProps, ServiceNode, ServiceEdge, ServiceMapProps. src/charts/Chart.tsx, ServiceMap.tsx, renderer.ts — remove unused @ts-expect-error directives now that types resolve; cast cytoscape through unknown for the extension registration; widen CytoElement fields to overlap with cytoscape's EdgeSingular type. src/components.d.ts — delete (stale duplicate of components.ts; main renamed it in b43d802 and the PR branch had reintroduced it). README.md.bundle — delete (transit artifact, not for git). pnpm-lock.yaml — regenerate to add the 7 new chart peer-deps (uplot, d3-hierarchy, d3-force, cytoscape, cytoscape-cose-bilkent, @deck.gl/core, @deck.gl/layers). tests/unit/setup.ts — stub ResizeObserver (jsdom doesn't implement it; charts use it to track container width). tests/unit/ServiceMap.test.tsx — new smoke test for the headline chart component. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aksOps
force-pushed
the
feat/charts-and-service-map
branch
from
902e367 to
2030f79
Compare
The design system uses Bricolage Grotesque (display), Plus Jakarta Sans (body), and Geist Mono (code) — declared via @font-face in colors_and_type.css. The Inter and JetBrainsMono woff2 files added by the PR are not referenced in any @font-face, CSS rule, preview HTML, or source file, so they're dead weight in the repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Until now the auto-generators only saw runtime exports from src/index.tsx, so charts had source files, README copy, and CHANGELOG entries — but were absent from the live docs site, llms.txt, and llms-full.txt. AI agents querying llms.txt couldn't discover charts at all. scripts/parse-source.mjs: - Add parseChartsExports() that reads src/charts/index.ts and returns Map<name, fileBasename>. Restricted to files with a capitalised basename so utility re-exports (./theme, ./renderer) don't surface as components. scripts/build-llms.mjs: - New "Charts (subpath)" category with a CHART_PEER_DEPS map. - llms.txt header counts core + chart components separately and notes the subpath. Usage example imports from both entry points. - llms-full.txt entries for charts include source path under src/charts/, the import line with the /charts subpath, and a per-component peer-deps callout. scripts/build-docs.mjs: - New "Charts" docs category. Chart pages live at /docs/<Name>/ alongside core components but render with subpath-aware metadata: src/charts/<Name>.tsx in the source line, /charts in the import, a Peer dependencies block, and a CHART_DEMOS map providing the canonical static example. Live preview is intentionally skipped (charts aren't in the IIFE bundle) — replaced with a deck-pattern placeholder that links to the matching preview/components-charts-* spec card. - New CSS for .demo-render--static, .demo-static-note, ul.peer-deps. - Final log line shows the core/chart split. package.json: bump 0.2.1 → 0.3.0 to match the [0.3.0] CHANGELOG entry that the original feature commit had already prepared. Verified: typecheck clean, 143/143 unit tests pass, build:site emits 58 component pages (51 core + 7 charts) across 9 categories; llms.txt grows from 6.8 KB to 7.8 KB and lists every chart under the new section; llms-full.txt grows from 27 KB to 34.7 KB and includes prop tables, import lines, and peer-dep callouts for all 7 charts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.