ci: scale-tag nightly + drop scale tests from PR CI#75
Merged
Conversation
Before: three long-running regression tests used `testing.Short()`
guards to stay out of `go test -short` local runs, but CI never
passed `-short` so they ran on every PR:
- TestImportTar_TotalBytesCap (~8s, 520 MB tar payload)
- TestScale_1000Notes (~10s, 1k file writes)
- TestHNSW_Recall10k (~55s, 10k-vector index build)
After: each lives in a dedicated `_scale_test.go` file behind
`//go:build scale` and is compiled only when the tag is passed. PR
CI drops ~70s per run; correctness coverage stays intact via the
new `nightly.yml` workflow that runs `-tags "sqlite_fts5 scale"` at
06:00 UTC and on workflow_dispatch.
Side effects:
- The old `if raceEnabled { t.Skip }` guard in TestHNSW_Recall10k
is retired because nightly runs the scale tests without `-race`
(workload is sequential — concurrency coverage lives in
TestHNSW_ConcurrentAddSearch, which still runs under -race on
every PR).
- normalizeVec moved into hnsw_recall_scale_test.go (its only
caller) so default test builds no longer carry dead helpers.
Closes #62, #63, #64.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//go:build scale:TestImportTar_TotalBytesCap(520 MB tar payload, ~8s)TestScale_1000Notes(1k file writes, ~10s)TestHNSW_Recall10k(10k-vector index build, ~55s).github/workflows/nightly.ymlruns-tags "sqlite_fts5 scale"at 06:00 UTC daily + workflow_dispatch.normalizeVechelper moves intohnsw_recall_scale_test.go(its only caller).Closes #62, #63, #64.
Test Plan