Merged
Conversation
- remove convenience using `MediaType` (alternatively use the `some MediaTypeProtocol` convenience logic) - `String` now conforms to `HTTPRequestMethodProtocol` - use `String` for the convenient `Route` methods (prevously required the http request method package traits)
- merged behind compilation conditions (and removed some package traits) - merge `GenericHTTPMessage` into `HTTPMessage` - merge `GenericStaticRoute` into `StaticRoute` - merge `GenericDynamicRoute` into `DynamicRoute` - merge `GenericDynamicResponse` into `DynamicResponse` - moved some protocols and structs to `DestinyEmbedded` - added `EMBEDDED` package trait to emulate building for embedded - removed some obsolete convenient inits and funcs
- some code formatting updates to convenient funcs - update imports and parsing function visibility in `HTTPRequestMethodExtensions.swift` - remove `DestinyDefaults` import in `Route+Convenience+Copyable.swift` (and fix a TODO typo)
- use `HTTPResponseMessageHead` in more places - significant changes to `Route` convenience to reduce code duplication and bloat (indirectly fixes missing additional headers and cookies) - added `@inlinable` (if enabled via package trait) to `HTTPRequestMenthodExtensions`
RandomHashTags
added
enhancement
- they now get upgraded to a `StaticString` if possible - any string body now includes the pound delimiter when expanded, if present - performance changes to `IntermediateResponseBody`
- minor documentation updates - add warning to `Router+Routes+Static` if appending isn't supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to reduce code duplication & bloat, and also unify implementations (and so we don't end up maintaining separate implementations based on enabled features)