-
Notifications
You must be signed in to change notification settings - Fork 8
Update to newest non v1 of embedded-hal #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to newest non v1 of embedded-hal #23
Conversation
|
|
||
| [dependencies] | ||
| embedded-hal = "=0.2.2" | ||
| embedded-hal = "0.2.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My plan here is to eventually have embedded-hal-02 and embedded-hal-1 and support both traits from this library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to just support whatever is newest. Nothing is dependent. Is there going to be added complexity supporting both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd make it much easier for me to support just v1. Supporting both is possible (it's even done in the embassy-rs crate itself) but it's a hassle for sure. I think I'd end up adding feature flags to support both.
I only intend to use v1 but I'll leave this up to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just keep it at v1 and we'll cross that bridge when we get there.
I'm a little concerned this bump will break the Embedded Linux HAL as all of the examples target the Raspberry Pi
c901cc6
Do you know if this breaks anything there? Could you go and add cargo check to the CI process and then rebase this on top of that? At least then I don't have to question if this stuff compiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v1 should be fine as linux-embedded-hal's newest version is 0.4.0 and it looks like they target v1 as well.
@RandomInsano Do you mind merging #24 and I can rebase this PR on it? That PR has a check to ensure that I don't regress linux builds
|
Absolutely! Just a one line fix needed over there and I'll merge it in. I'll try and keep my e-mail open to catch when that happens :) |
|
Thanks for all the work getting things up to date here! |
Updates the library to the most current 0.2.x version of embedded hal. Also fixed these deprecations and warnings after the update:
Warnings