Closed
Conversation
…/RScore into development-guidelines
TheoPannetier
commented
Nov 28, 2023
Comment on lines
+113
to
+116
|
|
||
| if (gen.trait1Chromosome) { | ||
| pGenome = new Genome(pSpecies->getNChromosomes(), pSpecies->getNLoci(0), | ||
| pSpecies->isDiploid()); |
Member
Author
There was a problem hiding this comment.
git is getting confused from here onwards, but all I did was fix the indentation, and remove the commented out DEBUGLOG lines. Jump to the bottom to see the draft test!
minor changes (references to other repositories, added roles of maintainers (Theo RScore + batch & Jette RScore + R package), emphasized contacting developer team for new features
Status check is not deployed on `development-guidelines`, I would postpone the requirement until `unit_test` is merged.
I hate pointers and their fandom
Member
Author
|
main and GHA workflow have been deployed, but unit tests are not yet ready. Closing this for now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
Depends on:
(please review & merge
cmake_batchfirst!)There is no reason for unit tests to be done through one of the interfaces - they should instead be run within the core code directly, so that we are confident that the tests hold true for all interfaces.
To enable this, I have written a simple
mainto allow RScore to run on its own without an interface.mainonly runs the unit tests, and exits with0if all tests complete successfully (or1otherwise).The tests themselves are only drafts so far, I will populate the test functions with unit tests this week.
Having RScore running on its own also enables continuous integration, so I deployed it (
check.yml, see the successful build here).