Skip to content

Comments

Import syn types explicitly#110

Merged
Rantanen merged 1 commit intoRantanen:masterfrom
Fluxie:explicit-syn
Dec 16, 2018
Merged

Import syn types explicitly#110
Rantanen merged 1 commit intoRantanen:masterfrom
Fluxie:explicit-syn

Conversation

@Fluxie
Copy link
Contributor

@Fluxie Fluxie commented Dec 15, 2018

Syn exports its own Result type which conflicts with the standard Result type leading to compilation errors.

@codecov-io
Copy link

codecov-io commented Dec 15, 2018

Codecov Report

Merging #110 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   81.37%   81.35%   -0.02%     
==========================================
  Files          57       57              
  Lines        5068     5068              
==========================================
- Hits         4124     4123       -1     
- Misses        944      945       +1
Impacted Files Coverage Δ
intercom-common/src/attributes/com_interface.rs 96.82% <ø> (ø) ⬆️
intercom-common/src/attributes/com_impl.rs 100% <ø> (ø) ⬆️
intercom-common/src/ast_converters.rs 38.27% <ø> (ø) ⬆️
intercom-common/src/returnhandlers.rs 85.71% <ø> (ø) ⬆️
intercom-common/src/attributes/com_class.rs 100% <ø> (ø) ⬆️
intercom-common/src/methodinfo.rs 90.77% <100%> (ø) ⬆️
intercom-common/src/lib.rs 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdfc47...9c4b8ab. Read the comment docs.

…licts with the standard Result type leading to compilation errors.
@Rantanen
Copy link
Owner

Oh, this explains why it was working on my system. Cargo.lock must have prevented Syn updates. Thanks!

@Rantanen Rantanen merged commit ef7e10e into Rantanen:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants