Skip to content

Converge Integration for startup#211

Merged
david-rfai merged 5 commits intomainfrom
ConvergeIntegration2
Apr 6, 2026
Merged

Converge Integration for startup#211
david-rfai merged 5 commits intomainfrom
ConvergeIntegration2

Conversation

@david-rfai
Copy link
Copy Markdown
Collaborator

@david-rfai david-rfai commented Apr 6, 2026

Changes

  • Option to disable starting frontend
  • If using Converge, sets RF_MLFLOW_ENABLED and RF_TENSORBOARD_ENABLED to true
  • On startup show correct log information depending on frontend source

Changelog Content

Additions

  • Option to disable starting frontend

Changes

  • If using Converge, sets RF_MLFLOW_ENABLED and RF_TENSORBOARD_ENABLED to true

Fixes

  • On startup show correct log information depending on frontend source

Note

Medium Risk
Changes service-startup orchestration (frontend/Converge/MLflow/TensorBoard) and port/log handling, which could affect local launch behavior across modes. Risk is limited to dev/runtime startup flow and is reversible via env flags.

Overview
Adds a new rapidfireai start --no-frontend flag (and RF_START_FRONTEND=false) to skip starting the Flask dashboard while still running the API and enabled tracking services.

Improves Converge startup behavior in setup/start.sh: auto-disables Converge when rapidfireai-pro isn’t installed, ensures Converge forces RF_MLFLOW_ENABLED and RF_TENSORBOARD_ENABLED on, and refines service counting, port checks, status output, and log reporting (including converge_frontend.log/converge_backend.log) to match what was actually started.

Reviewed by Cursor Bugbot for commit ca0f8f2. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Autofix Details

Bugbot Autofix prepared fixes for all 3 issues found in the latest run.

  • ✅ Fixed: Inverted condition hides converge_frontend.log in wrong modes
    • Changed != to == in the condition to correctly show converge_frontend.log only when RF_CONVERGE_MODE is 'all' or 'frontend'.
  • ✅ Fixed: Inverted condition hides converge_backend.log in wrong modes
    • Changed != to == in the condition to correctly show converge_backend.log only when RF_CONVERGE_MODE is 'all' or 'backend'.
  • ✅ Fixed: Startup aborts on busy frontend port despite --no-frontend
    • Added RF_START_FRONTEND check to skip frontend port validation when the frontend is intentionally disabled via --no-frontend flag.

Create PR

Or push these changes by commenting:

@cursor push 9766a7c994
Preview (9766a7c994)
diff --git a/setup/start.sh b/setup/start.sh
--- a/setup/start.sh
+++ b/setup/start.sh
@@ -313,9 +313,11 @@
         print_error "MLflow $RF_MLFLOW_HOST:$RF_MLFLOW_PORT in use"
         return 1
     fi
-    if ping_port $RF_FRONTEND_HOST $RF_FRONTEND_PORT; then
-        print_error "Frontend $RF_FRONTEND_HOST:$RF_FRONTEND_PORT in use"
-        return 1
+    if [[ "$RF_START_FRONTEND" == "true" ]]; then
+        if ping_port $RF_FRONTEND_HOST $RF_FRONTEND_PORT; then
+            print_error "Frontend $RF_FRONTEND_HOST:$RF_FRONTEND_PORT in use"
+            return 1
+        fi
     fi
     if ping_port $RF_API_HOST $RF_API_PORT; then
         print_error "API port $RF_API_HOST:$RF_API_PORT in use"
@@ -812,7 +814,7 @@
         fi
     fi
 
-    if [[ "$RF_START_FRONTEND" == "true" ]] && { [[ "$RF_CONVERGE_MODE" == "all" ]] || [[ "$RF_CONVERGE_MODE" != "frontend" ]]; }; then
+    if [[ "$RF_START_FRONTEND" == "true" ]] && { [[ "$RF_CONVERGE_MODE" == "all" ]] || [[ "$RF_CONVERGE_MODE" == "frontend" ]]; }; then
         if [[ -f "$RF_LOG_PATH/converge_frontend.log" ]]; then
             local size=$(du -h "$RF_LOG_PATH/converge_frontend.log" | cut -f1)
             print_status "- $RF_LOG_PATH/converge_frontend.log: $size"
@@ -821,7 +823,7 @@
         fi
     fi
 
-    if [[ "$RF_CONVERGE_MODE" == "all" ]] || [[ "$RF_CONVERGE_MODE" != "backend" ]]; then
+    if [[ "$RF_CONVERGE_MODE" == "all" ]] || [[ "$RF_CONVERGE_MODE" == "backend" ]]; then
         if [[ -f "$RF_LOG_PATH/converge_backend.log" ]]; then
             local size=$(du -h "$RF_LOG_PATH/converge_backend.log" | cut -f1)
             print_status "- $RF_LOG_PATH/converge_backend.log: $size"

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ca0f8f2. Configure here.

@david-rfai david-rfai merged commit b0ff6ab into main Apr 6, 2026
3 checks passed
@david-rfai david-rfai deleted the ConvergeIntegration2 branch April 6, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants