Conversation
Code Review — PR #528: adjusted ai agents skills docsThis PR consolidates the Claude Code-specific docs into a broader multi-agent page and removes the migration guide. The direction is sound, but there are a few issues worth addressing before merging. Issues1. Migration guide deletion is unrelated to the PR goal (potential breaking change for users)
2. Claude Code command syntax changed without verification Old New These are different execution contexts. The old format used Claude Code slash commands (typed inside a Claude Code session), while the new format uses shell CLI invocations. Please verify the new commands actually work as written — a user following the doc should be able to copy-paste them into a terminal, not a Claude Code prompt. 3. "40+ more" claim is unsubstantiated
4. Missing content from the old Two sections didn't carry over to
The second one in particular is useful for teams — it lets contributors get prompted to install the marketplace automatically. Consider adding an equivalent section or footnote in 5. Minor: casing inconsistency Old docs: GitHub org names are case-insensitive so this is harmless, but the new version ( Summary
The consolidation from agent-specific to multi-agent docs is a good improvement. The migration guide removal feels like a separate, unintentional deletion — worth double-checking whether it was intentional. |
PR Review: adjusted ai agents skills docsOverall this is a sensible direction — consolidating from a Claude-Code-only page into a multi-agent page makes sense as the skill broadens its reach. A few issues worth addressing before merge: Issues1. Inconsistent Claude Code interface in the same file The install table uses CLI syntax: But the "Keeping the skill up to date" section uses slash-command syntax: These are different interfaces (terminal vs. in-app command). Pick one and stay consistent, or at minimum explain the distinction. If the install is done via CLI, the update should also show a CLI equivalent alongside the slash command. 2. The deleted 3. Migration guide deleted without replacement
This deletion also feels unrelated to the stated goal of the PR (expanding AI agent coverage). Worth splitting into a separate PR if intentional. 4. "Any other" install command is underspecified Without 5. Dropped content from The deleted file included two sections that had real value and aren't in the new file:
The second one in particular is not obvious to find elsewhere. Worth porting to the new file. Minor
|
|
test |
PR Review: adjusted ai agents skills docsSummaryThis PR replaces the Claude Code-specific plugin doc and migration guide with a new multi-agent Issues1. Migration guide removed with no replacement
Consider keeping the migration guide, or moving its content elsewhere (e.g. a condensed section in the quickstart). At minimum, confirm the removal is intentional. 2. Claude Code install command inconsistency The new doc shows a CLI invocation: The old Two differences to resolve:
3. Lost content: project-level plugin setup The old 4. Tone Per the CLAUDE.md guidelines, docs should not fall into hyperbole. A few lines read as marketing copy:
Fine for a landing page, but out of place in technical documentation. A plain description would be more appropriate. Minor
VerdictGood direction overall. Suggested follow-ups:
|
No description provided.