Improves behaviour with no matlab engine#44
Merged
alexhroom merged 2 commits intoRascalSoftware:mainfrom Apr 22, 2025
alexhroom:better-no-matlab
Merged
Improves behaviour with no matlab engine#44alexhroom merged 2 commits intoRascalSoftware:mainfrom alexhroom:better-no-matlab
alexhroom merged 2 commits intoRascalSoftware:mainfrom
alexhroom:better-no-matlab
Conversation
DrPaulSharp
reviewed
Apr 17, 2025
DrPaulSharp
approved these changes
Apr 17, 2025
Collaborator
DrPaulSharp
left a comment
DrPaulSharp
left a comment
There was a problem hiding this comment.
Thanks for getting on this so promptly, the code works as expected, and it's definitely a lot nicer to drop the number of matlab engine warnings!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for the docs to build with no MATLAB engine (by moving the loading of convert_rascal) and also makes the logs output less when MATLAB engine is not present.