Skip to content

Insert parameter after selected row#218

Merged
StephenNneji merged 3 commits intoRascalSoftware:mainfrom
StephenNneji:select_row
Apr 23, 2026
Merged

Insert parameter after selected row#218
StephenNneji merged 3 commits intoRascalSoftware:mainfrom
StephenNneji:select_row

Conversation

@StephenNneji
Copy link
Copy Markdown
Contributor

@StephenNneji StephenNneji commented Apr 20, 2026

Closes #176

This PR adds row numbers to the project tables and the ability to add new entry after a selected row

Screenshot 2026-04-20 102456

Also changed the appearance of the cells in the Bayesian columns to indicate when they cannot be changed

Screenshot 2026-04-21 102156

Copy link
Copy Markdown
Collaborator

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, there's just one thing I'd like you to have a look at. If you add a parameter after an intermediate row, the new parameter then appears to be selected. However, if you immediately add another parameter, it appears at the end of the list. Could you take a look at the appearance of a new parameter to make the fact it is not selected clearer.

Comment thread rascal2/widgets/project/tables.py Outdated
@StephenNneji
Copy link
Copy Markdown
Contributor Author

This looks good, there's just one thing I'd like you to have a look at. If you add a parameter after an intermediate row, the new parameter then appears to be selected. However, if you immediately add another parameter, it appears at the end of the list. Could you take a look at the appearance of a new parameter to make the fact it is not selected clearer.

The selected row should look like this

Screenshot 2026-04-20 160234

while the added row should look like

Screenshot 2026-04-20 160251

I think its very distinct, are you seeing something else?
I kept the invalid (grey) name highlight so its easier for the user to see where the param was added

@DrPaulSharp
Copy link
Copy Markdown
Collaborator

Ahh, somehow I hadn't noticed that in focussing on the bold parameter number on the left hand side. Ok, I'm less bothered now, but if it's easy to un-bold the new number I think it would be worth doing, but let me know what you think.

@StephenNneji
Copy link
Copy Markdown
Contributor Author

Ahh, somehow I hadn't noticed that in focussing on the bold parameter number on the left hand side. Ok, I'm less bothered now, but if it's easy to un-bold the new number I think it would be worth doing, but let me know what you think.

I will investigate

@StephenNneji StephenNneji merged commit d8a78e1 into RascalSoftware:main Apr 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible to add parameter after a selected row?

2 participants