fix: unpkg import in Getting Started codelab for blockly v11#2379
Merged
BeksOmega merged 3 commits intoRaspberryPiFoundation:masterfrom May 29, 2024
Merged
fix: unpkg import in Getting Started codelab for blockly v11#2379BeksOmega merged 3 commits intoRaspberryPiFoundation:masterfrom
BeksOmega merged 3 commits intoRaspberryPiFoundation:masterfrom
Conversation
BeksOmega
reviewed
May 29, 2024
Contributor
BeksOmega
left a comment
There was a problem hiding this comment.
Hey Mark! Thanks for the fix :D
Could you actually change it to match the usage we document on devsite?
<!-- Load Blockly core -->
<script src="https://unpkg.com/blockly/blockly_compressed.js"></script>
<!-- Load the default blocks -->
<script src="https://unpkg.com/blockly/blocks_compressed.js"></script>
<!-- Load a generator -->
<script src="https://unpkg.com/blockly/javascript_compressed.js"></script>
<!-- Load a message file -->
<script src="https://unpkg.com/blockly/msg/en.js"></script>Also @cpcallen just in case this wasn't expected to change.
Contributor
Author
Sure. I'll just point out that a few other examples also currently use "https://unpkg.com/blockly/blockly.min.js" |
Contributor
Author
|
@BeksOmega Do you want me to include the comments for those loads in the code and the codelab? |
Contributor
Nah leaving them out is fine! |
BeksOmega
approved these changes
May 29, 2024
Contributor
BeksOmega
left a comment
There was a problem hiding this comment.
Thanks again for the fix Mark!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2378
Proposed Changes
Change the unpkg import to be valid.
Reason for Changes
See #2378 for more info.
Test Coverage
Documentation
This PR updates the codelab documentation.
Additional Information