Skip to content

fix: unpkg import in Getting Started codelab for blockly v11#2379

Merged
BeksOmega merged 3 commits intoRaspberryPiFoundation:masterfrom
mit-cml:fix-for-blockly-v11
May 29, 2024
Merged

fix: unpkg import in Getting Started codelab for blockly v11#2379
BeksOmega merged 3 commits intoRaspberryPiFoundation:masterfrom
mit-cml:fix-for-blockly-v11

Conversation

@mark-friedman
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #2378

Proposed Changes

Change the unpkg import to be valid.

Reason for Changes

See #2378 for more info.

Test Coverage

Documentation

This PR updates the codelab documentation.

Additional Information

@mark-friedman mark-friedman requested a review from a team as a code owner May 28, 2024 22:00
@mark-friedman mark-friedman requested review from BeksOmega and removed request for a team May 28, 2024 22:00
@mark-friedman mark-friedman changed the title Fix for blockly v11 Fix unpkg in Getting Started codelab for blockly v11 May 28, 2024
@mark-friedman mark-friedman changed the title Fix unpkg in Getting Started codelab for blockly v11 fix: unpkg import in Getting Started codelab for blockly v11 May 28, 2024
Copy link
Copy Markdown
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mark! Thanks for the fix :D

Could you actually change it to match the usage we document on devsite?

<!-- Load Blockly core -->
<script src="https://unpkg.com/blockly/blockly_compressed.js"></script>
<!-- Load the default blocks -->
<script src="https://unpkg.com/blockly/blocks_compressed.js"></script>
<!-- Load a generator -->
<script src="https://unpkg.com/blockly/javascript_compressed.js"></script>
<!-- Load a message file -->
<script src="https://unpkg.com/blockly/msg/en.js"></script>

Also @cpcallen just in case this wasn't expected to change.

@mark-friedman
Copy link
Copy Markdown
Contributor Author

Could you actually change it to match the usage we document on devsite? ...

Sure. I'll just point out that a few other examples also currently use "https://unpkg.com/blockly/blockly.min.js"

@mark-friedman
Copy link
Copy Markdown
Contributor Author

@BeksOmega Do you want me to include the comments for those loads in the code and the codelab?

@BeksOmega
Copy link
Copy Markdown
Contributor

BeksOmega commented May 29, 2024

@BeksOmega Do you want me to include the comments for those loads in the code and the codelab?

Nah leaving them out is fine!

Copy link
Copy Markdown
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the fix Mark!

@BeksOmega BeksOmega merged commit 3e76926 into RaspberryPiFoundation:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Getting started" example won't run due to its unpkg import being invalid

2 participants