Check for duplicates
Description
I'm unsure what the intended behaviour of Escape is in the flyout and toolbox.
In the flyout, Escape currently does nothing. In the previous keyboard nav implementation (plugin), Escape in the flyout closed the flyout and focused the workspace.
In the toolbox, Escape closes the flyout, but keeps the toolbox category focused (but not visually). If you press the left or right arrows while the toolbox is in this state, an error is thrown:
i_collapsible_toolbox_item.ts:45 Uncaught TypeError: Cannot read properties of null (reading 'getChildToolboxItems')
at isCollapsibleToolboxItem (i_collapsible_toolbox_item.ts:45:16)
at Toolbox.toggleSelectedItem (toolbox.ts:970:7)
at Toolbox.onKeyDown_ (toolbox.ts:313:24)
at HTMLDivElement.wrapFunc (browser_events.ts:71:14)
In the previous keyboard nav implementation (plugin), Escape in toolbox closed the flyout and focused the workspace.
Reproduction steps
- Use keyboard navigation to focus the toolbox - the flyout will open (do not navigate into the flyout)
- Press Escape to close the flyout
- Press the right or left arrow key
Priority
No response
Stack trace
Screenshots
No response
Browsers
No response
Check for duplicates
Description
I'm unsure what the intended behaviour of Escape is in the flyout and toolbox.
In the flyout, Escape currently does nothing. In the previous keyboard nav implementation (plugin), Escape in the flyout closed the flyout and focused the workspace.
In the toolbox, Escape closes the flyout, but keeps the toolbox category focused (but not visually). If you press the left or right arrows while the toolbox is in this state, an error is thrown:
In the previous keyboard nav implementation (plugin), Escape in toolbox closed the flyout and focused the workspace.
Reproduction steps
Priority
No response
Stack trace
Screenshots
No response
Browsers
No response