Edit generators to read in Variable Models.#1107
Merged
marisaleung merged 1 commit intoRaspberryPiFoundation:developfrom May 17, 2017
Merged
Edit generators to read in Variable Models.#1107marisaleung merged 1 commit intoRaspberryPiFoundation:developfrom
marisaleung merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
Contributor
|
Did you miss Lua? Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Contributor
Author
|
Lua actually never used variableList so a replacement isn't necessary. Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Collaborator
|
It looks like Lua doesn't have special declaration of global variables. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit, generators read the variable model name instead of the whole variable model.
This change is