Fix require#1108
Conversation
marisaleung
force-pushed
the
FixRequire
branch
4 times, most recently
from
eb24d73 to
95b96da
Compare
core/workspace.js
Outdated
|
|
||
| goog.require('goog.array'); | ||
| goog.require('goog.math'); | ||
| goog.require('Blockly.VariableMap'); |
There was a problem hiding this comment.
Nit: can you put this before goog.array so it is alphabetical?
core/workspace.js
Outdated
| */ | ||
| 'use strict'; | ||
|
|
||
| goog.require('Blockly.VariableMap'); |
There was a problem hiding this comment.
doh. Sorry. The require should be after the provide... I think our eslint rules enforce this... but I'm not certain.
|
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. core/workspace.js, line 27 at r1 (raw file):
Too far. After the provide (provide should always be above the requires) Comments from Reviewable |
|
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions. core/workspace.js, line 27 at r1 (raw file): Previously, picklesrus wrote…
Done. core/workspace.js, line 27 at r1 (raw file): Previously, RoboErikG wrote…
Done. Comments from Reviewable |
3 participants
This change is