Skip to content

Small fix#1113

Merged
marisaleung merged 1 commit intoRaspberryPiFoundation:developfrom
marisaleung:SmallFix
May 23, 2017
Merged

Small fix#1113
marisaleung merged 1 commit intoRaspberryPiFoundation:developfrom
marisaleung:SmallFix

Conversation

@marisaleung
Copy link
Copy Markdown
Contributor

@marisaleung marisaleung commented May 18, 2017

Changed variable to variable_name to make it clear that the parameter is a string and not a variableModel.


This change is Reviewable

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@marisaleung marisaleung changed the base branch from master to develop May 18, 2017 21:12
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@RoboErikG
Copy link
Copy Markdown
Contributor

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@marisaleung marisaleung merged commit e841216 into RaspberryPiFoundation:develop May 23, 2017
@marisaleung marisaleung deleted the SmallFix branch May 23, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants