Clean-up dependencies in package.json#1853
Merged
AnmAtAnm merged 3 commits intoRaspberryPiFoundation:developfrom May 15, 2018
Merged
Clean-up dependencies in package.json#1853AnmAtAnm merged 3 commits intoRaspberryPiFoundation:developfrom
AnmAtAnm merged 3 commits intoRaspberryPiFoundation:developfrom
Conversation
AnmAtAnm
commented
May 14, 2018
| "dependencies": { | ||
| "google-closure-library": "^20180204.0.0", | ||
| "gulp": "^3.9.1", | ||
| "install": "^0.8.8", |
Contributor
Author
There was a problem hiding this comment.
I think this line was mistakenly added by an accidental npm install install command.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Incorrect dependencies in package.json
Proposed Changes
devDependencies. Removing unused dependencies.Reason for Changes
Clean-up
Test Coverage
Ran
npminstall on clean copy of this branch of the repo (git archive | tar -x ...).Awaiting a pass on Travis.