Fix zelos top row spacer height when it precedes a statement row.#3587
Merged
samelhusseini merged 1 commit intoRaspberryPiFoundation:developfrom Jan 14, 2020
Merged
Conversation
samelhusseini
changed the title
alschmiedt
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fix zelos top spacer height when the top row precedes a statement row.
Proposed Changes
Give preference to the followsStatement check before checking if the prev row is a top row and applying the top row check.
Reason for Changes
Zelos rendering.
Test Coverage
Tested in playground with new connection test blocks.
Tested on:
Documentation
Additional Information