Adds select logic#4081
Merged
alschmiedt merged 3 commits intoRaspberryPiFoundation:toolboxfrom Jul 28, 2020
Merged
Conversation
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
A few nits, but looks good overall. Thanks for breaking this up for review.
| Blockly.utils.aria.State.ACTIVEDESCENDANT, ''); | ||
| } | ||
|
|
||
| if (newItem && newItem != oldItem ) { |
Collaborator
There was a problem hiding this comment.
Can you handle the case where newItem == oldItem explicitly and earlier in the function? I see you're checking this twice.
Contributor
Author
There was a problem hiding this comment.
Not that I have been able to figure out.
Mostly because of this line (!oldItem.isCollapsible() || oldItem != newItem).
This covers the case where we don't deselect a category if it is collapsible.
Collaborator
There was a problem hiding this comment.
Discussed offline and approved as-is or with a simple comment change.
rachel-fenichel
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Adds logic in for selecting a toolbox item.
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information