Adds keyboard and onClick logic#4083
Merged
alschmiedt merged 2 commits intoRaspberryPiFoundation:toolboxfrom Aug 4, 2020
Merged
Adds keyboard and onClick logic#4083alschmiedt merged 2 commits intoRaspberryPiFoundation:toolboxfrom
alschmiedt merged 2 commits intoRaspberryPiFoundation:toolboxfrom
Conversation
maribethb
approved these changes
Aug 4, 2020
| * @param {!Event} e Click event to handle. | ||
| * @protected | ||
| */ | ||
| Blockly.Toolbox.prototype.onClick_ = function(e) { |
Contributor
There was a problem hiding this comment.
Do protected functions normally end in underscores too? I'm genuinely asking because I haven't used protected very often. The style guide only mentions it being required for private, but afaict it doesn't say you can't for other visibilities so I'm not sure.
Contributor
Author
There was a problem hiding this comment.
In Blockly yes, but I am not entirely sure what the norm for this is or what the story is behind why blockly does this.
alschmiedt
added a commit
to alschmiedt/blockly
that referenced
this pull request
Aug 7, 2020
alschmiedt
added a commit
to alschmiedt/blockly
that referenced
this pull request
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Handles keyboard events and clicking on the toolbox and toolbox items.
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information