Add separator for toolbox#4089
Merged
alschmiedt merged 3 commits intoRaspberryPiFoundation:toolboxfrom Aug 3, 2020
Merged
Conversation
moniika
approved these changes
Jul 29, 2020
Contributor
moniika
left a comment
moniika
left a comment
There was a problem hiding this comment.
Some notes about jsdoc clarification, otherwise looks good.
core/toolbox/separator.js
Outdated
| * @type {!Blockly.ToolboxSeparator.ClassConfig} | ||
| * @protected | ||
| */ | ||
| this.classConfig_ = { |
Contributor
There was a problem hiding this comment.
I think some confusion I'm having is with usage of the term classes. Class could be either referring to JavaScript class or css class, after looking a bit longer it seems like this is about css. Maybe mentioning css in the JsDoc would make this clearer.
Contributor
Author
There was a problem hiding this comment.
I added what I think is a better comment, but would it also help to name these cssConfig_ instead of classConfig_?
Contributor
There was a problem hiding this comment.
I think cssConfig_ could also help. I do like the jsdoc comment changes.
moniika
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Adds a toolbox separator class.
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information