Support dispatching pointer events in click tests#4154
Merged
moniika merged 4 commits intoRaspberryPiFoundation:developfrom Aug 11, 2020
Merged
Support dispatching pointer events in click tests#4154moniika merged 4 commits intoRaspberryPiFoundation:developfrom
moniika merged 4 commits intoRaspberryPiFoundation:developfrom
Conversation
moniika
changed the title
3 tasks
alschmiedt
approved these changes
Aug 11, 2020
| var flyout = this.workspace.flyout_; | ||
| chai.assert.exists(this.workspace.flyout_, | ||
| 'Precondition: missing flyout'); | ||
| flyout.autoClose = true; |
Contributor
There was a problem hiding this comment.
This is flyout.autoClose = false in the original. Was this meant to be changed?
Contributor
Author
There was a problem hiding this comment.
Yes, in the original the flyout autclose and always open tests were the same due to copy paste error. This fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #4065
Proposed Changes
Reason for Changes
Simulating click lets us test event propogation. Gesture tests were refactored to test that helper works.
Test Coverage
Ran mocha tests.
Tested on:
Additional Information
Testing event firing in gesture test will be in a separate PR.