fix(build): Correct typos in PR #7169#7197
Merged
cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom Jun 22, 2023
Merged
fix(build): Correct typos in PR #7169#7197cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom
cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
Three separate mistakes left only the Python and PHP chunks with the correct code for the legacy script exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Three separate mistakes left only the Python and PHP chunks with the correct code for the legacy script exports.
Proposed Changes
Fix typos
Behaviour Before Change
Only
python_compressed.jsandphp_compressed.jshad correct code for legacy exports (Blockly.<Lang>) in their UMD wrappers.Behaviour After Change
All five
<lang>_compressed.jschunks get correct wrappers.Reason for Changes
Don't want to break developer's code.
Test Coverage
Output manually checked.