fix: Utilize getIcon instead of getCommentIcon in tests#7200
Merged
BeksOmega merged 3 commits intoRaspberryPiFoundation:developfrom Jun 23, 2023
Merged
Conversation
itsjayway
changed the title
itsjayway
changed the title
BeksOmega
suggested changes
Jun 23, 2023
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
Thanks for the fix, this looks great :D Just one fixup and then this should be good to go!
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Jun 23, 2023
cpcallen
reviewed
Jun 28, 2023
| sharedTestSetup, | ||
| sharedTestTeardown, | ||
| } from './test_helpers/setup_teardown.js'; | ||
| import {CommentIcon} from '../../core/icons/comment_icon.js'; |
Collaborator
There was a problem hiding this comment.
I believe this should have been from '../../build/src/core/icons/comment_icon.js' (here and below).
We are now seeing build warnings that I believe are due to this; I'm actually not certain how this test is running successfully as I would not expect the import as written to work at all:
Could not find "../../core/icons/comment_icon.js".Assuming it (and its transitive dependencies) are non-Closure managed. /Users/cpcallen/src/blockly/tests/mocha/comment_deserialization_test.js
Could not find "../../core/icons/comment_icon.js".Assuming it (and its transitive dependencies) are non-Closure managed. /Users/cpcallen/src/blockly/tests/mocha/contextmenu_items_test.js
...
1 task
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jul 7, 2023
Tweak the test files touched by PR RaspberryPiFoundation#7200 to be consistent with existing usage of Blockly.icons.CommentIcon instead of importing this separately.
4 tasks
cpcallen
added a commit
that referenced
this pull request
Jul 7, 2023
* fix(tests): Fix invalid import paths in mocha tests This resolves the warnings generated during buildDeps by closure-make-deps. This commit does not attempt to address #7224 or otherwise rationalise the imports and usage thereof. * fix(tests): Fix failing context menu item test Test appears to have been wrong: Block.prototype.getIcon is typed as getIcon<T extends IIcon>(/* ... */): T | undefined and documented as "@returns The icon with the given type if it exists on the block, undefined otherwise." * refactor(tests): Clean up inconsistent usage of CommentIcon Tweak the test files touched by PR #7200 to be consistent with existing usage of Blockly.icons.CommentIcon instead of importing this separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7164
Proposed Changes
utilize
getIcon()in preparation for v11Behavior Before Change
Behavior After Change
Reason for Changes
Test Coverage
npm run test:mocha:interactive-> check consoleDocumentation
Removed deprecation function, docstring, and dependencies from
block_svg.tsAdditional Information
N/A