Skip to content

chore: remove js-green-licenses#7201

Merged
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:developfrom
rachel-fenichel:remove_check_licenses
Jun 27, 2023
Merged

chore: remove js-green-licenses#7201
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:developfrom
rachel-fenichel:remove_check_licenses

Conversation

@rachel-fenichel
Copy link
Copy Markdown
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Proposed Changes

Remove the js-green-licenses package and references to it.

Behavior Before Change

We had a manually-executable gulp command to check licenses, which we never used.

Behavior After Change

No license command, and a slightly smaller dependency tree.

Reason for Changes

There are other ways to check licenses for a package, that don't involve pulling this into our dev dependencies.

Additional Information

This does not need to land before the next release--I can always rebase it--but it shouldn't break anything since it was all unused.

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner June 23, 2023 16:46
@rachel-fenichel rachel-fenichel requested a review from cpcallen June 23, 2023 16:46
@github-actions github-actions Bot added the PR: chore General chores (dependencies, typos, etc) label Jun 23, 2023
Copy link
Copy Markdown
Collaborator

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that all this can be replaced with a single npx js-green-licenses <some additional args?> call. Might it be worth documenting that in our (internal or external) documentation?

Or maybe keep the license script in package.json but have it use npx?

@rachel-fenichel
Copy link
Copy Markdown
Collaborator Author

Given that I have no record of us using the license check in automated or manual releases, I'd rather just delete it.

@rachel-fenichel rachel-fenichel merged commit e2cd1ba into RaspberryPiFoundation:develop Jun 27, 2023
@rachel-fenichel rachel-fenichel deleted the remove_check_licenses branch June 27, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants