chore: remove js-green-licenses#7201
Merged
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:developfrom Jun 27, 2023
rachel-fenichel:remove_check_licenses
Merged
chore: remove js-green-licenses#7201rachel-fenichel merged 1 commit intoRaspberryPiFoundation:developfrom rachel-fenichel:remove_check_licenses
rachel-fenichel merged 1 commit intoRaspberryPiFoundation:developfrom
rachel-fenichel:remove_check_licenses
Conversation
cpcallen
approved these changes
Jun 26, 2023
Collaborator
cpcallen
left a comment
There was a problem hiding this comment.
I'm guessing that all this can be replaced with a single npx js-green-licenses <some additional args?> call. Might it be worth documenting that in our (internal or external) documentation?
Or maybe keep the license script in package.json but have it use npx?
maribethb
approved these changes
Jun 26, 2023
Collaborator
Author
|
Given that I have no record of us using the license check in automated or manual releases, I'd rather just delete it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Proposed Changes
Remove the
js-green-licensespackage and references to it.Behavior Before Change
We had a manually-executable gulp command to check licenses, which we never used.
Behavior After Change
No
licensecommand, and a slightly smaller dependency tree.Reason for Changes
There are other ways to check licenses for a package, that don't involve pulling this into our dev dependencies.
Additional Information
This does not need to land before the next release--I can always rebase it--but it shouldn't break anything since it was all unused.