fix: properly pass the block to the icon constructor in blockfactory blocks#7202
Merged
BeksOmega merged 1 commit intoRaspberryPiFoundation:developfrom Jun 23, 2023
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
maribethb
approved these changes
Jun 23, 2023
BeksOmega
force-pushed
the
fix/block-factory-fields
branch
from
3c21a30 to
b20e066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Properly passes the block to the mutator icon constructor in the block factory demos.
Behavior Before Change
The block factory field blocks would cause console errors.
Behavior After Change
No Errors
Reason for Changes
The block factory should be usable!
Test Coverage
N/A
Documentation
Going to update the description of the mutator refactor PR to include info about needing to pass the block to the constructor. Previously passing the block was optional (even though it was not marked as optional).
Additional Information
N/A