chore: change the way we look for upstream remote#7230
Merged
maribethb merged 3 commits intoRaspberryPiFoundation:developfrom Aug 4, 2023
Merged
chore: change the way we look for upstream remote#7230maribethb merged 3 commits intoRaspberryPiFoundation:developfrom
maribethb merged 3 commits intoRaspberryPiFoundation:developfrom
Conversation
Contributor
Author
|
@cpcallen can you run |
rachel-fenichel
approved these changes
Jun 30, 2023
cpcallen
requested changes
Jun 30, 2023
thanks christopher Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
cpcallen
approved these changes
Jul 5, 2023
Collaborator
|
@maribethb: are you thinking of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes the fact that
npm run updateGithubPagesdid not run for meProposed Changes
Changes the methodology for finding a git remote name. The old way doesn't work for me because the output of
git remote -vlooks like this for me (snippet):(ok that probably didn't work, but it seems like there's an extra tab between the name and the url, idk why)
Also, the url text the old way was looking for doesn't work for me because I use SSH for git, not HTTPS.
Behavior Before Change
Assumes the user is using https. Assumes there is only one tab in the git output :/
Behavior After Change
Hopefully finds the upstream remote name for everyone!
Reason for Changes
I'm trying to update github pages
Test Coverage
Prettttty sure this works locally, but hard to test the entire process given that the
updateGithubPagesscript stashes and resets git branches. I tested by commenting out all the parts of the task except the one that fetches the remote.Documentation
no
Additional Information
gh-pagesbranch locally, checking out a new copy based on develop (which you can do via specifying the remote URL instead of the name), then force pushing to overwrite the remote version of gh-pages branch at the end. I think that would work. But this is less of a change and I think this should also work, so we'll see?