fix: have icons use the new render management system#7296
Merged
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom Jul 24, 2023
Merged
fix: have icons use the new render management system#7296BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
BeksOmega merged 2 commits intoRaspberryPiFoundation:developfrom
Conversation
This was referenced Jul 19, 2023
cpcallen
approved these changes
Jul 24, 2023
Collaborator
cpcallen
left a comment
There was a problem hiding this comment.
Make sure that this PR still has a deprecation tag once it's been submitted: one of the bots seems to like to try to remove that tag.
Not for this PR, but: given similarity of code have you considered introducing a BubbleIcon intermediate class between Icon and Comment/Mutator/WarningIcon?
aedf2b9 to
edf338d
Compare
Contributor
Author
|
Maribeth actually requested on the next pull request that I remove the dummy promises, and we just cleanly break people later. So I've reverted that change and removed the deprecation notice! [Edit: Wrt the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #7068
Proposed Changes
setBubbleVisiblemethods.Reason for Changes
Test Coverage
All tests pass! Also quickly tested
block.setCommentText('test'); block.getIcon('comment').setBubbleVisible(true);in the browser console to reassure myself that it was indeed working.