fix(blocks): boolean variable block wrong shape for zelos#7335
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
43b4ed2 to
533230a
Compare
533230a to
9df7f9d
Compare
BeksOmega
left a comment
There was a problem hiding this comment.
Thank you for finding this bug and submitting a fix :D The change looks great, but I think there's actually a more general place we can put it!
| if (this.rendered) { | ||
| (this as BlockSvg).queueRender(); | ||
| } |
There was a problem hiding this comment.
Instead of having this inside the individual block definition, you can override setCheck in the rendered connection class, and call queueRender there! This way whenever a connection check gets updated on any block, we'll be sure the shapes of the connections get updated =)
There was a problem hiding this comment.
Thank you for taking the time to review my PR and providing your feedback. I appreciate your suggestions. updated
BeksOmega
left a comment
There was a problem hiding this comment.
Sweet, LGTM! I'll get this merged after CI Passes =) Thank you for your hard work on this!!
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7334
Proposed Changes
Behavior Before Change
Behavior After Change
Reason for Changes
I think it's a bug 🤔️
Test Coverage
Documentation
Additional Information
Is there a better way than rerender?