fix: text join block warning when using block-plus-minus plugin #7598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Oct 20, 2023
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks great, thank you for the fix!
HadyBazzi
deleted the
fix/text-join-block-warning-when-using-block-plus-minus-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
When combined with RaspberryPiFoundation/blockly-samples#2025 this resolves RaspberryPiFoundation/blockly-samples#1134.
Proposed Changes
Register the quote_image_mixin.
Reason for Changes
This allows the block-plus-minus plugin to access the mixin which stops the following warning (when combined with RaspberryPiFoundation/blockly-samples#2025) from appearing when using the text_join block with the plugin:
field named "TEXT" not found in "text_join" blockAdditional Information
The passing of this should be followed by the passing of RaspberryPiFoundation/blockly-samples#2025.