chore(build): Set "type": "commonjs" in dist/package.json#8097
Merged
cpcallen merged 1 commit intoRaspberryPiFoundation:rc/v11.0.0from May 13, 2024
Merged
Conversation
As described this should be a no-op, but by publishing it now in v11 it will help discover any compatibility issues with 3rd party build tools that might change how the process the package when it is present.
cpcallen
added
component: build process
PR: chore
github-actions
Bot
added
PR: chore
maribethb
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Set
"type": "commonjs"in the generateddist/package.jsonfile, since the.jsfiles in the package root are CJS. This should be a no-op since that's the default, but by setting it explicitly we ensure that any change to the repository top-level package.json to set "type": "module" won't break the published package accidentally.Reason for Changes
As described this should be a no-op, but by publishing it now in v11 it will help discover any compatibility issues with 3rd party build tools that might change how the process the package when it is present.
Test Coverage
npm testnpm testin blockly-samples when linked against adist/build with this change.No changes to manual test procedures needed.