Skip to content

fix: delete area animation#8149

Merged
BeksOmega merged 3 commits intoRaspberryPiFoundation:developfrom
BeksOmega:fix/delete-area-animation
May 20, 2024
Merged

fix: delete area animation#8149
BeksOmega merged 3 commits intoRaspberryPiFoundation:developfrom
BeksOmega:fix/delete-area-animation

Conversation

@BeksOmega
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #8098

Proposed Changes

Hacks some things around to get delete animations to work. Everything should be internal. Please check!

Test Coverage

Documentation

Once we add an animation API we'll need to add those side effect requirements to the dragger docs.

Additional Information

@BeksOmega BeksOmega requested a review from a team as a code owner May 17, 2024 18:52
@BeksOmega BeksOmega requested a review from cpcallen May 17, 2024 18:52
@github-actions github-actions Bot added the PR: fix Fixes a bug label May 17, 2024
Comment thread core/dragging/dragger.ts Outdated
Comment thread core/layer_manager.ts
BeksOmega and others added 3 commits May 20, 2024 16:54
Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
@BeksOmega BeksOmega force-pushed the fix/delete-area-animation branch from 5c6e191 to f02fd5d Compare May 20, 2024 16:54
@BeksOmega BeksOmega merged commit 7c4b0bd into RaspberryPiFoundation:develop May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete animation and sound don't play when dragging blocks to a delete area.

2 participants