Skip to content

fix: collapsed warning propagation across siblings (#9566)#9567

Merged
gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom
goughjo02:fix/9566-collapsed-warning-sibling
Jan 13, 2026
Merged

fix: collapsed warning propagation across siblings (#9566)#9567
gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom
goughjo02:fix/9566-collapsed-warning-sibling

Conversation

@goughjo02
Copy link
Contributor

The basics

The details

Resolves

Fixes #9566

Proposed Changes

  • Add a regression test for collapsed blocks inheriting warnings from following sibling stacks.
  • Update collapsed warning propagation to ignore following siblings.

Reason for Changes

Collapsed blocks should only surface warnings from blocks contained within them. Warnings from following siblings are misleading and don’t represent the collapsed block’s contents.

Test Coverage

  • Added a Mocha regression test in tests/mocha/block_test.js.
  • Manual verification in playground: collapse a block in a stack where the next sibling has a warning; the collapsed block should not show a warning.

Documentation

No documentation updates needed.

Additional Information

screenshot of the fix (compare with screenshots on issue)

Screenshot 2026-01-13 at 11 39 43

@goughjo02 goughjo02 requested a review from a team as a code owner January 13, 2026 11:40
@goughjo02 goughjo02 requested a review from gonfunko January 13, 2026 11:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@goughjo02 goughjo02 force-pushed the fix/9566-collapsed-warning-sibling branch from 51f43b8 to cbca29d Compare January 13, 2026 11:43
@goughjo02 goughjo02 changed the title Fix collapsed warning propagation across siblings (#9566) fix: collapsed warning propagation across siblings (#9566) Jan 13, 2026
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 13, 2026
@gonfunko
Copy link
Contributor

Thanks for catching this, and thanks very much for the fix and test!

@gonfunko gonfunko merged commit a4d97c2 into RaspberryPiFoundation:main Jan 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapsed block incorrectly shows warnings from following sibling stack

2 participants

Comments