Conversation
github-actions
bot
added
breaking change
github-actions
bot
added
breaking change
1 task
maribethb
approved these changes
Feb 26, 2026
.github/workflows/browser_test.yml
Outdated
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 6 * * 1' # Runs every Monday at 06:00 UTC | ||
| - cron: "0 6 * * 1" # Runs every Monday at 06:00 UTC |
Contributor
There was a problem hiding this comment.
any particular reason for this change? we use single quotes elsewhere in this file and generally
Contributor
Author
There was a problem hiding this comment.
Autoformatter did it 🤷♂️ Reverted though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR updates the Node version support matrix for v13 to be Node 22 and 24. Node 18 is EOL and Node 20 will be EOL in April, which is likely before Blockly v13 will be released. We may want to add Node 26 depending on when the release occurs, but it's not yet available. Although Blockly itself doesn't need this, it seems the general approach in the ecosystem is to keep these within the LTS range, and this will allow us to update more dependencies that we'd otherwise be stuck on old versions of because they have dropped support for Node versions we're still treating as supported.