Skip to content

fix!: Improve keyboard navigation of icons and bubbles#9737

Merged
gonfunko merged 3 commits intov13from
blub-blub
Apr 20, 2026
Merged

fix!: Improve keyboard navigation of icons and bubbles#9737
gonfunko merged 3 commits intov13from
blub-blub

Conversation

@gonfunko
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #9720

Proposed Changes

This PR improves the interaction of keyboard navigation with icons and bubbles. Now, for all kinds of built-in bubbles:

  • Open bubbles are treated as part of the first row of the block, and are navigable with left/right
  • When a bubble is focused, M may be used to move it, Escape may be used to close it, and (for mutator and comment bubbles) Enter may be used to move to its mutator workspace/comment editor
  • Mutator bubbles don't highlight the text of blocks in the mutator toolbox when they are focused

Breaking Changes

  • Blockly.BlockCommentNavigationPolicy has been replaced with a more-generic Blockly.BubbleNavigationPolicy, which should be used in place of it.

@gonfunko gonfunko requested a review from a team as a code owner April 20, 2026 18:20
@gonfunko gonfunko requested a review from maribethb April 20, 2026 18:20
@github-actions github-actions Bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Apr 20, 2026
Comment thread packages/blockly/tests/mocha/keyboard_navigation_test.js Outdated
@gonfunko gonfunko merged commit 80ee2d5 into v13 Apr 20, 2026
4 checks passed
@gonfunko gonfunko deleted the blub-blub branch April 20, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants