feat: Update zelos path object to allowlist attributes#9742
Merged
lizschwab merged 1 commit intoRaspberryPiFoundation:v13from Apr 21, 2026
Merged
feat: Update zelos path object to allowlist attributes#9742lizschwab merged 1 commit intoRaspberryPiFoundation:v13from
lizschwab merged 1 commit intoRaspberryPiFoundation:v13from
Conversation
gonfunko
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9665
Proposed Changes
In the Zelos renderer, the
updateSelected()method now creates a new element to assign to thesvgPathSelectedelement rather than cloning thesvgPath.Reason for Changes
This allows us to create an allowlist of attributes we want to copy rather than a denylist of attributes, which was how we previously handled it. Ultimately, this allows us to avoid inadvertently copying attributes that may cause issues in the accessibility tree.
Test Coverage
I have tested these changes manually by comparing the functionality before and after these changes in Chrome. Keyboard navigation and focus control all continued to work when using the Zelos renderer in the Advanced Blockly Playground after these changes were applied.
Accessibility tree before:
Accessibility tree after:
