fix: dont activate base delete areas for keyboard moves#9748
Merged
maribethb merged 2 commits intoRaspberryPiFoundation:v13from Apr 22, 2026
Merged
fix: dont activate base delete areas for keyboard moves#9748maribethb merged 2 commits intoRaspberryPiFoundation:v13from
maribethb merged 2 commits intoRaspberryPiFoundation:v13from
Conversation
gonfunko
approved these changes
Apr 22, 2026
Contributor
Author
|
added tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9721
Proposed Changes
wouldDeletesince it was not different than the base implementation (please double check me on that)Reason for Changes
The reason I chose this approach is it updates the default delete area to not trigger for keyboard moves, but allows developers to customize it if they do want their delete areas to trigger for keyboard moves
An alternative was to have the dragger just not fire any of the drag target methods if the drag target was also a delete area. but that was actually more complicated due to various factors (e.g. if you are moving from a regular drag target to a delete area, you have to make sure to trigger the
onDragExitfor the regular drag target but NOT trigger theonDragEnterfor the delete area). And it's less customizable and explainable for developers implementing their own drag targets.Test Coverage
i will add a test case for this before i merge this but wanted to get review on the approach first because i have another commitment today before i can write the test
Documentation
we don't have any documentation for delete areas but if we did we should tell developers they should probably not activate them for keyboard moves
Additional Information