feat: Display keyboard shortcuts in context menus#9785
Merged
Conversation
1 task
Contributor
Author
|
Refactored this to use |
maribethb
reviewed
May 4, 2026
Contributor
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
can you please also update the PR description to avoid referencing the compatibility table you refactored out, it makes the release notes confusing
github-actions
Bot
added
PR: feature
maribethb
approved these changes
May 5, 2026
Collaborator
|
@gonfunko A head's up that this causes aria-labels for context menu items to be '[object HTMLDivElement]' due to this fallback option of using String(this.content) which is now getting passed an HTML element instead of a string. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9739
Proposed Changes
This PR displays keyboard shortcuts associated with context menu items in the context menu. Context menu items that perform the same action as a keyboard shortcut should add the name the shortcut is registered under to their
associatedKeyboardShortcutfield to inform Blockly of the relationship between them.