Skip to content

feat!: Added additional keyboard shortcuts for context menu#9845

Merged
lizschwab merged 2 commits into
RaspberryPiFoundation:v13from
lizschwab:rpf-622
May 11, 2026
Merged

feat!: Added additional keyboard shortcuts for context menu#9845
lizschwab merged 2 commits into
RaspberryPiFoundation:v13from
lizschwab:rpf-622

Conversation

@lizschwab
Copy link
Copy Markdown
Contributor

@lizschwab lizschwab commented May 8, 2026

The basics

The details

Resolves

Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#622

Proposed Changes

Adds context menu shortcuts for Shift+F10 and the Menu key.

Reason for Changes

These are common shortcuts for the context menu in Windows.

Test Coverage

Added unit tests for validating the context menu appears from a block, from a workspace comment, and from the workspace when pressing these key combinations. Tested manually (my keyboard does have a menu button).

Breaking Changes

New keyboard shortcuts have been registered for Shift+F10 and the Menu/Context Menu key. This will cause an error if you try to register another shortcut with these same keys. If you already have one or both of these keyboard shortcuts registered for something in your code, you will need to either change which key(s) your shortcut uses or remove the new registration(s) to keep your existing shortcut(s).

@lizschwab lizschwab requested a review from a team as a code owner May 8, 2026 00:24
@lizschwab lizschwab requested a review from gonfunko May 8, 2026 00:25
@lizschwab lizschwab changed the title Rpf 622 feat: Added additional keyboard shortcuts for context menu May 8, 2026
@github-actions github-actions Bot added the PR: feature Adds a feature label May 8, 2026
@lizschwab lizschwab requested a review from mikeharv May 8, 2026 16:27
Copy link
Copy Markdown
Contributor

@mikeharv mikeharv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for adding test coverage. I think this may need to be marked as a breaking change, in case developers have already assigned the new shortcuts to other functionality.

@lizschwab lizschwab changed the title feat: Added additional keyboard shortcuts for context menu feat!: Added additional keyboard shortcuts for context menu May 11, 2026
@github-actions github-actions Bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature and removed PR: feature Adds a feature breaking change Used to mark a PR or issue that changes our public APIs. labels May 11, 2026
@lizschwab lizschwab merged commit c185d0f into RaspberryPiFoundation:v13 May 11, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants