fix: skip empty label fields and dummy/end row inputs for move announcements#9847
Merged
mikeharv merged 7 commits intoMay 11, 2026
Merged
Conversation
mikeharv
changed the title
lizschwab
approved these changes
May 11, 2026
Contributor
lizschwab
left a comment
lizschwab
left a comment
There was a problem hiding this comment.
Once the override issue is addressed this is good to merge
lizschwab
reviewed
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes
Proposed Changes
This updates the way unlabeled inputs are counted, in order to skip dummy and end row inputs.
It also updates
FieldLabelto allow for empty string ARIA labels (which are then ignored for input/block).The before screenshot below shows incorrect input counting due to the presence of a dummy input. It also shows an
'empty'label due to a blank field that is used to assist in laying out the block.After these changes, the input index is reported in a more intuitive way and the 'empty' label field is skipped entirely:
Reason for Changes
These changes are important in order to make sure that inputs are described more helpfully, and that superfluous block layout information is not conveyed to assistive technologies.
Test Coverage
New tests were added to ensure we do not count dummy and end row inputs when announcing moves involving unlabeled inputs.