Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/blockly/core/inject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function createMainWorkspace(
if (!wsOptions.hasCategories && wsOptions.languageTree) {
// Add flyout as an <svg> that is a sibling of the workspace SVG.
const flyout = mainWorkspace.addFlyout(Svg.SVG);
dom.insertAfter(flyout, svg);
injectionDiv.insertBefore(flyout, svg);
}
if (wsOptions.hasTrashcan) {
mainWorkspace.addTrashcan();
Expand Down
2 changes: 1 addition & 1 deletion packages/blockly/core/toolbox/toolbox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ export class Toolbox

this.HtmlDiv = this.createDom_(this.workspace_);
const flyoutDom = this.flyout.createDom('svg');
workspace.getInjectionDiv().insertBefore(flyoutDom, svg);
dom.addClass(flyoutDom, 'blocklyToolboxFlyout');
dom.insertAfter(flyoutDom, svg);
this.setVisible(true);
this.flyout.init(workspace);

Expand Down
18 changes: 18 additions & 0 deletions packages/blockly/tests/mocha/toolbox_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,24 @@ suite('Toolbox', function () {
Blockly.getFocusManager().focusNode(this.toolbox.getWorkspace());
assert.isTrue(this.toolbox.getFlyout().isVisible());
});

test('Tab order follows toolbox, flyout, workspace DOM order', function () {
const injectionDiv = this.toolbox.getWorkspace().getInjectionDiv();
const children = Array.from(injectionDiv.children);

const toolboxIndex = children.indexOf(this.toolbox.HtmlDiv);
const flyoutIndex = children.indexOf(this.toolbox.getFlyout().svgGroup_);
const workspaceIndex = children.indexOf(
this.toolbox.getWorkspace().getParentSvg(),
);

assert.isAtLeast(toolboxIndex, 0);
assert.isAtLeast(flyoutIndex, 0);
assert.isAtLeast(workspaceIndex, 0);

assert.isBelow(toolboxIndex, flyoutIndex);
assert.isBelow(flyoutIndex, workspaceIndex);
});
});

suite('onClick_', function () {
Expand Down
Loading