Bug fix: Allow saving of new files added to project #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validations for component Use cancancan load_and_authorize_resource in projects controller.
…ow_saving_of_new_files_added_to_project
loiswells97
reviewed
Mar 10, 2022
Contributor
loiswells97
left a comment
loiswells97
left a comment
There was a problem hiding this comment.
Just a few minor comments/questions from me:
- Should the errors say ''cannot" instead of "can not" in config/locales/en.yml?
- What does
accepts_nested_attributes :componentsdo in app/models/project.rb?
ArayB
deleted the
issues/27-Bug_fix_Allow_saving_of_new_files_added_to_project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a project we need to support the following functionality:
main.py) This can not be deleted or have its name or extension changed but it can have its content changed.closes Bug fix: Allow saving of new files added to project #27